This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Reuse existing tabs when opening files from changes tree#1585
Merged
jcansdale merged 4 commits intofeature/pr-reviews-masterfrom Apr 10, 2018
Merged
Reuse existing tabs when opening files from changes tree#1585jcansdale merged 4 commits intofeature/pr-reviews-masterfrom
jcansdale merged 4 commits intofeature/pr-reviews-masterfrom
Conversation
This requires that when we extract a file to a temp file, that the same file at the same commit is always extracted to the same location. To do this, we use a hash of the file's relative path in the repository and the encoding as the temp directory name, and place the commit sha in the temp file's filename.
Move `GetSha256Hash` into `StringExtensions` as it's needed in >1 place.
18 tasks
Also fix unit test for `no body/>0 file comments` case - it wasn't correct before as it was assigning a body.
17 tasks
jcansdale
reviewed
Apr 9, 2018
Collaborator
jcansdale
left a comment
There was a problem hiding this comment.
This is working well. 😄
Looks like a couple of stray commits snuck in (e.g. Allow request changes with only file comments.).
jcansdale
approved these changes
Apr 10, 2018
Collaborator
jcansdale
left a comment
There was a problem hiding this comment.
Looks good, works well. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following issue in #1570:
To test
Implementation
This requires that when we extract a file to a temp file, that the same file at the same commit is always extracted to the same location. To do this, we use a hash of the file's relative path in the repository and the encoding as the temp directory name, and place the commit sha in the temp file's filename.
Depends on #1582
Part of #1491